close re-render/etc issues if nothing is needed #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks @dougalsutherland. Not sure what happened to CI. So went ahead and restarted it. |
|
I just checked and tests pass locally, but the Travis build blew up again. Will look into it a little later, though I can't imagine this change is what broke it... 😕 |
|
Example failure: #54 (comment) It's a conda-forge/conda-smithy#871; guess we'll either need a new conda-smithy release or to pin |
isuruf
reviewed
Aug 10, 2018
| @@ -1,4 +1,5 @@ | |||
| conda-smithy>=3 | |||
| ruamel.yaml==0.15.51 # until https://github.com/conda-forge/conda-smithy/pull/871 | |||
There was a problem hiding this comment.
@dougalsutherland, does 0.15.51 work? We may have to pin it back to 0.15.50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226.